Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpFoundation] Do not set X-Accel-Redirect for paths outside of X-Accel-Mapping #31654

Merged

Commits on May 28, 2019

  1. [HttpFoundation] Do not set X-Accel-Redirect for paths outside of X-A…

    …ccel-Mapping
    
    Currently BinaryFileResponse, when configured with X-Accel-Redirect sendfile type,
    will only substitute file paths specified in X-Accel-Mapping. But if the provided
    file path does not have a defined prefix, then the resulting header will include
    the absolute path. Nginx expects a valid URI, therefore this will result in an
    issue that is very hard to detect and debug as it will not show up in error logs
    and instead the request would just hang for some time and then be re-served
    without query parameters(?).
    vilius-g committed May 28, 2019
    Copy the full SHA
    a662f61 View commit details
    Browse the repository at this point in the history