[WebProfilerBundle] Makes it possible to work with the profiler on another vhost #31557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…other vhost there's already a few places where the link is an absolute url but the toolbar item are host relative, I think this is the only place where it's missing
carsonbot
added
Status: Needs Review
WebProfilerBundle
Bug
and removed
Status: Needs Review
labels
Simperfit
approved these changes
May 21, 2019
samnela
approved these changes
May 21, 2019
nicolas-grekas
approved these changes
May 21, 2019
|
I just remembered about #31349. Closing as duplicate, thanks for submitting. Please review this other PR if you don't mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when the profiler is not on the same vhost than the page we're working on, the profiler links are not working
there's already a few places where the link is an absolute url but the toolbar item are host relative, I think this is the only place where it's missing