Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ProxyManager] isProxyCandidate() does not take into account interfaces #31551

Merged
merged 1 commit into from May 20, 2019

Commits on May 20, 2019

  1. [Bridge\ProxyManager] isProxyCandidate() does not take into account i…

    …nterfaces
    
    When using factories it's common best practice to use interface as class name, especially in cases
    where you know impl can differ. Before this fix ProxyManager did not allow these to be lazy.
    
    In our case this has lead several to hard to debug issues on classes we need to mark as lazyi
    and often a need to add lazy on decorators if there are any or other workarounds.
    As we have had this issue, and still have on both 2.8 and 3.4 this is opened against 2.8.
    andrerom committed May 20, 2019
    Copy the full SHA
    e3739b1 View commit details
    Browse the repository at this point in the history