Use the current working dir as default first arg in 'link' binary #31510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i think this change is fine. Perhaps check if we exec edit: not sure we have to care about that actually |
Simperfit
approved these changes
May 18, 2019
nicolas-grekas
approved these changes
May 18, 2019
fabpot
approved these changes
May 18, 2019
|
Thank you @lyrixx. |
fabpot
added a commit
that referenced
this pull request
May 18, 2019
… binary (lyrixx) This PR was merged into the 3.4 branch. Discussion ---------- Use the current working dir as default first arg in 'link' binary | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | I don't know how you work on symfony, but each time I face the same issue 1. I go on lyrixx/symfony (my fork) 1. I execute `pwd` and copy it 1. I go to an application 1. I paste the cwd + add `/link` and hit enter 1. I got an error because I missed the "target" 1. I replay the last command and add ` .` With this PR, I will save the last 2 items... Event if it's a "new feature", I targeted 3.4. Commits ------- 6b76c36 Use the current working dir as default first arg in 'link' binary
This was referenced May 22, 2019
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know how you work on symfony, but each time I face the same issue
pwdand copy it/linkand hit enter.With this PR, I will save the last 2 items...
Event if it's a "new feature", I targeted 3.4.