Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Translation] Fixes typo in comment #31342

Closed
wants to merge 1 commit into from
Closed

[Translation] Fixes typo in comment #31342

wants to merge 1 commit into from

Conversation

jschaedl
Copy link
Contributor

@jschaedl jschaedl commented May 1, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

@nicolas-grekas
Copy link
Member

What's the lowest branch where the typo exists?

@jschaedl
Copy link
Contributor Author

jschaedl commented May 1, 2019

What's the lowest branch where the typo exists?

It's 2.8: https://github.com/symfony/symfony/blob/2.8/src/Symfony/Component/Translation/Util/ArrayConverter.php

@jschaedl jschaedl changed the base branch from master to 2.8 May 1, 2019 11:00
@jschaedl jschaedl changed the base branch from 2.8 to master May 1, 2019 11:00
@jschaedl jschaedl closed this May 1, 2019
@jschaedl jschaedl deleted the fix-typo branch May 1, 2019 11:06
@jschaedl
Copy link
Contributor Author

jschaedl commented May 1, 2019

@nicolas-grekas Should this fix go into 3.4 then?

@jschaedl
Copy link
Contributor Author

jschaedl commented May 1, 2019

#31343

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review Translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jschaedl @nicolas-grekas @carsonbot