Fix name and phpdoc of ContainerBuilder::removeBindings #31173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
teohhanhui
commented
Apr 18, 2019
teohhanhui
commented
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #29944 (comment) |
| License | MIT |
| Doc PR | N/A |
nicolas-grekas
approved these changes
Apr 18, 2019
teohhanhui
changed the title
|
The method name was also wrong. It's okay to change because it's |
OskarStark
approved these changes
Apr 19, 2019
teohhanhui
changed the title
|
Even if the method is marked as internal, we won't rename the method in 3.4 as this is not a bug fix. So, the phpdoc can be merged in 3.4, but the rest should be done in master. |
|
These methods have been released for the 1st time 10 days ago, see #29944 |
xabbuh
approved these changes
Apr 27, 2019
|
Thank you @teohhanhui. |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 27, 2019
…(teohhanhui) This PR was merged into the 3.4 branch. Discussion ---------- Fix name and phpdoc of ContainerBuilder::removeBindings | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes | Fixed tickets | #29944 (comment) | License | MIT | Doc PR | N/A <!-- Write a short README entry for your feature/bugfix here (replace this comment block.) This will help people understand your PR and can be used as a start of the Doc PR. Additionally: - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. --> Commits ------- c93194d Fix name and phpdoc of ContainerBuilder::removeBindings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.