[Serializer] Deprecate calling createChildContext without the format parameter #31030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
changed the title
dbu
changed the title
jewome62
approved these changes
Apr 10, 2019
nicolas-grekas
requested changes
Apr 15, 2019
src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php
Show resolved
Hide resolved
dbu
force-pushed
the
serializer-cache-key-method-deprecation
branch
from
d5b0776
to
fb73b72
Compare
|
i updated to your comments @nicolas-grekas . okay like this? |
maxhelias
approved these changes
May 14, 2019
fabpot
requested changes
May 15, 2019
src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php
Outdated
Show resolved
Hide resolved
dbu
force-pushed
the
serializer-cache-key-method-deprecation
branch
2 times, most recently
from
ea05e7b
to
da3411d
Compare
fabpot
reviewed
May 15, 2019
src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php
Outdated
Show resolved
Hide resolved
dbu
force-pushed
the
serializer-cache-key-method-deprecation
branch
from
da3411d
to
5363647
Compare
fabpot
approved these changes
May 15, 2019
fabpot
force-pushed
the
serializer-cache-key-method-deprecation
branch
from
5363647
to
cb77902
Compare
|
Thank you @dbu. |
fabpot
added a commit
that referenced
this pull request
May 15, 2019
…out the format parameter (dbu) This PR was submitted for the master branch but it was merged into the 4.3 branch instead (closes #31030). Discussion ---------- [Serializer] Deprecate calling createChildContext without the format parameter | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - as discussed in #30907 deprecate omitting the format parameter when extending the AbstractNormalizer. Commits ------- cb77902 deprecate calling createChildContext without the format parameter
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Jun 8, 2019
…anagi) This PR was merged into the 5.0-dev branch. Discussion ---------- [Serializer] Remove last deprecated/obsolete paths | Q | A | ------------- | --- | Branch? | master <!-- see below --> | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #28316, #28709, #31030, #27020, #29896, 16f8a13#r201060750 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A <!-- required for new features --> This should fix the last deprecations & obsolete code paths for the Serializer component. Commits ------- c703b35 [Serializer] Remove last deprecated/obsolete paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed in #30907 deprecate omitting the format parameter when extending the AbstractNormalizer.