[Cache] fix using ProxyAdapter inside TagAwareAdapter #30918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmaicher
commented
Apr 6, 2019
|
@nicolas-grekas I implemented what we discussed yesterday 👍 |
nicolas-grekas
approved these changes
Apr 7, 2019
|
Thank you @dmaicher. |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 7, 2019
…icher) This PR was merged into the 3.4 branch. Discussion ---------- [Cache] fix using ProxyAdapter inside TagAwareAdapter | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #30400 | License | MIT | Doc PR | - EUFOSSA After some debugging this is my first attempt to fix this issue @nicolas-grekas 😊 Let's discuss it. without the fix the test fails like this: ``` Testing Symfony\Component\Cache\Tests\Adapter\TagAwareAndProxyAdapterIntegrationTest F 1 / 1 (100%) Time: 28 ms, Memory: 4.00MB There was 1 failure: 1) Symfony\Component\Cache\Tests\Adapter\TagAwareAndProxyAdapterIntegrationTest::testIntegration Failed asserting that Array &0 ( 'tag1' => 0 'tag2' => 0 ) is identical to 'bar'. /var/www/symfony/src/Symfony/Component/Cache/Tests/Adapter/TagAwareAndProxyAdapterIntegrationTest.php:26 FAILURES! Tests: 1, Assertions: 1, Failures: 1. Commits ------- 98b9be9 [Cache] fix using ProxyAdapter inside TagAwareAdapter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EUFOSSA
After some debugging this is my first attempt to fix this issue @nicolas-grekas 😊 Let's discuss it.
without the fix the test fails like this: