[FrameworkBundle][Routing] added Configurators to handle template and redirect controllers

[HeahDude]

Q	A
Branch?	master
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	let's see
Fixed tickets	partially #24640, #25145
License	MIT
Doc PR	symfony/symfony-docs#11120

While working on symfony/symfony-docs#11085, I felt bad about the long notations required for simple redirects and templates rendering template actions, but I love and use those features since always. Then I gave it a try yesterday night and now I realised I missed #24640 and that #25145 has been closed x).

So here we go, here's my WIP. WDYT of this implementation? ping @javiereguiluz?

I'm going to open the PR in the docs so we can discuss the DX changes there too, and keep focus on the code here.

Cheers!

EDIT

This PR now only update PHP-DSL configurators.

---

TODO:

• gather reviews
• [x] fix xml schema
• add some tests
• [ ] handle xsd auto discovery
• rebase on top of [Routing] Fixed XML options resolution #30507
• add shortcuts for [FrameworkBundle] Add a controller to send simple HTTP responses #30514

[HeahDude]

I'd really appreciate some help if anyone had already overridden some xsd schema thanks!

[HeahDude]

I've updated symfony/symfony-docs#11120 with a nice before/after view.

Also I need to rebase on top of #30507.

Xml config is working properly, but the IDE cannot resolve validation/autocompletion yet, this works thanks to the loader using its constant local path.
I guess we need to create a new path on https://symfony.com/routing that we need to declare explicitly in config/routes.xml or any xml file where this feature should be used, are you the one handling this @fabpot? Can you help me on this?

Apart this last points, the feature is ready from side, only reviews needed now :), thanks!

[javiereguiluz]

Thanks for working on this. To make this feature completely self-explanatory, I think we should rename redirect-to as redirect-to-route (we already have redirect-to-url). What do you think?

[HeahDude]

Rebased and squashed here, while I addressed @javiereguiluz's comment.

Also, I was not happy with the xml definition because all attributes are there and it's hard to guess which one to use in which context, so I propose to use dedicated types instead: https://github.com/symfony/symfony/compare/a46c76a8c3a05adb7f984ea4d9cffbd3a446f3f5..7055ba0a5b09cec84d88f5c0447e79b65aa48a85#diff-96d406b9b38189be981bbea1bad334bd.

Tests are passing locally and on travis, but not on windows.. I wonder how this line https://github.com/symfony/symfony/pull/30501/files#diff-44f544990841fe196e4ea5c76dcc18dfR8 can be a problem, if anyone has a clue on that topic that would be awesome.

[nicolas-grekas]

Did you consider this instead for the PHP-DSL?

    $routes->add('template_route', '/static')
        ->template('static.html.twig')
        ->maxAge(300)
        ->sharedMaxAge(100)
        ->private(true)
        ->methods(['GET'])
        ->options(['utf8' => true])
        ->condition('abc')
    ;
    $routes->add('redirect_route', '/redirect')
        ->redirectToRoute('target_route')
        ->permanent(true)
        ->ignoreAttributes(['attr', 'ibutes'])
        ->keepRequestMethod(true)
        ->keepQueryParams(true)
        ->schemes(['http'])
        ->host('legacy')
        ->options(['utf8' => true])
    ;
    $routes->add('url_redirect_route', '/redirect-url')
        ->redirectToUrl('/url-target')
        ->permanent(true)
        ->scheme('http')
        ->httpPort(1)
        ->httpsPort(2)
        ->keepRequestMethod(true)
        ->host('legacy')
        ->options(['utf8' => true])

[nicolas-grekas]

Now that #34873 is merged, can you please rebase and take it into account to inject your new ContainerConfigurator?

[nicolas-grekas]

Thank you @HeahDude.