[Config] ensure moving away from Serializable wont break cache:clear #30034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
unser-safe
branch
from
562ea51
to
9d3180a
Compare
xabbuh
approved these changes
Jan 30, 2019
nicolas-grekas
added a commit
that referenced
this pull request
Jan 30, 2019
…ache:clear (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [Config] ensure moving away from Serializable wont break cache:clear | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - When a resource implementation moves away from `Serializable`, the `cache:clear` command currently fails with `Warning: Class Symfony\Component\Config\Resource\ClassExistenceResource has no unserializer`. This change makes it ignore the failure, which is fine. Commits ------- 9d3180a [Config] ensure moving away from Serializable wont break cache:clear
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a resource implementation moves away from
Serializable, thecache:clearcommand currently fails withWarning: Class Symfony\Component\Config\Resource\ClassExistenceResource has no unserializer. This change makes it ignore the failure, which is fine.