[Form] Changed UrlType input type to text when default_protocol is not null

[MatTheCat]

Q	A
Branch?	3.4
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	#29690
License	MIT

[xabbuh]

@MatTheCat it looks like some tests need to be fixed

Status: Needs work

[MatTheCat]

@xabbuh I don't understand what's going on. I see tests failing on Symfony\Bridge\Twig\Tests\Extension\FormExtensionBootstrap3HorizontalLayoutTest::testUrl but this test doesn't exist anymore in this PR. Why do I see it?

Tests pass on my local branch.

[ro0NL]

we might gain some extra value to use inputmode=url when using type=text. AFAIK this will force a specific keyboard on mobile (e.g. URL input).

https://caniuse.com/#feat=input-inputmode

[ro0NL]

tested on android with built-in samsung keyboard, and works as expected 👍

[MatTheCat]

Don't know if failing tests prevent to merge this?

[MatTheCat]

@xabbuh what can I do to get this merged?

[MatTheCat]

@stof is it good now?

[MatTheCat]

@stof ?

[MatTheCat]

@fabpot could this PR be merged please?

[mablae]

@MatTheCat If you need to use your branch NOW, you could alias it via composer.json.
Here is shown how it is done: https://lornajane.net/posts/2014/use-a-github-branch-as-a-composer-dependency

Pushing for merge and mentioning fabpot seldom results in a faster merge. If the feature is good it will be merged. Please be a little more patient after putting lot of work into your PR.

And thank you for the work!

[MatTheCat]

I conclude the feature is not good so there's no point for me to continue rebasing my branch.

[mablae]

You're wrong. You already got positive feedback.

[MatTheCat]

Dude don't provoke me on my personal email. You're point is a PR is merged if it's good right? This one didn't.

Can we stop the conversation here?

[mablae]

good luck with that attitude. It is too sad, since your feature was pretty good. Your PR was also referred 4 days ago, so why are you on such a hurry? I am glad to help you setup your composer.json to use your branch NOW as mentioned. Best regards Malte Am Di., 22. Jan. 2019 um 13:19 Uhr schrieb Mathieu <notifications@github.com

…

: Dude don't provoke me on my personal email. You're point is a PR is merged if it's good right? This one didn't. Can we stop the conversation here? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#29691 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAXw8O217I8ZpvkYpHQ_JklTLbDnbw8Vks5vFwHfgaJpZM4Zh5Pn> .