Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes URI parsing #29631

Closed
wants to merge 1 commit into from
Closed

Fixes URI parsing #29631

wants to merge 1 commit into from

Conversation

ian-starts
Copy link

@ian-starts ian-starts commented Dec 17, 2018

When $this->server->get('REQUEST_URI'); passes //foo/bar the parse_url function assumes that foo is the host and not part of the path.

Q A
Branch? master for features / 3.4 up to 4.2 for bug fixes
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #...
License MIT
Doc PR symfony/symfony-docs#...

When $this->server->get('REQUEST_URI'); passes //foo/bar the parse_url function assumes that foo is the host and not part of the path.
@nicolas-grekas
Copy link
Member

Duplicate of #29494? Can you check if it fixes the same issue please?

@ian-starts
Copy link
Author

Duplicate of #29494? Can you check if it fixes the same issue please?
Ah you're right! Though I do (obviously) think that my solution is more elegant. But that's just vanity.

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Dec 17, 2018

think that my solution is more elegant

(See broken tests.)
It would if it were to work - and had new tests ;)
Just kidding.

Thanks for submitting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants