[Console] OutputFormatter: move strtolower to createStyleFromString #29619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While playing with the href feature that'll be available in 4.3, I spotted href value is lowercased. Which I guess could be an issue on case-sensitive filesystems. This changes nothing for the current branch, but will allow when merging to upper branches to fix the behavior described above, hence keep original case.
nicolas-grekas
approved these changes
Dec 15, 2018
chalasr
approved these changes
Dec 15, 2018
|
Thank you @ogizanagi. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 17, 2018
…romString (ogizanagi) This PR was merged into the 3.4 branch. Discussion ---------- [Console] OutputFormatter: move strtolower to createStyleFromString | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | not really | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | N/A <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A While playing with the href feature that'll be available in 4.3, I spotted href value [is lowercased](#29620). Which I guess could be an issue on case-sensitive filesystems. This changes nothing for the current branch, but will allow when merging to upper branches to fix the behavior described above, hence keep original case. Commits ------- 8e2bd35 [Console] OutputFormatter: move strtolower to createStyleFromString
symfony-splitter
pushed a commit
to symfony/console
that referenced
this pull request
Dec 17, 2018
This PR was merged into the 4.3-dev branch. Discussion ---------- [Console] Test href case conservation | Q | A | ------------- | --- | Branch? | master <!-- see below --> | Bug fix? | yes | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | no <!-- please add some, will be required by reviewers --> | Fixed tickets | N/A <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A Expecting this test to fail until symfony/symfony#29619 is merged up. Commits ------- 2b55d1504e [Console] Test href case conservation
nicolas-grekas
added a commit
that referenced
this pull request
Dec 17, 2018
This PR was merged into the 4.3-dev branch. Discussion ---------- [Console] Test href case conservation | Q | A | ------------- | --- | Branch? | master <!-- see below --> | Bug fix? | yes | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | no <!-- please add some, will be required by reviewers --> | Fixed tickets | N/A <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A Expecting this test to fail until #29619 is merged up. Commits ------- 2b55d15 [Console] Test href case conservation
This was referenced Jan 6, 2019
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While playing with the href feature that'll be available in 4.3,
I spotted href value is lowercased. Which I guess could be an issue on case-sensitive filesystems.
This changes nothing for the current branch, but will allow when merging
to upper branches to fix the behavior described above, hence keep original case.