Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection widget prototype fix #29547

Closed
wants to merge 30 commits into from

Commits on Oct 23, 2018

  1. Configuration menu
    Copy the full SHA
    2a4e2e6 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2018

  1. Configuration menu
    Copy the full SHA
    bb6be15 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2018

  1. [Workflow] Trigger entered event for subject entering in the Workfl…

    …ow for the first time
    lyrixx committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    388840f View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2018

  1. updated version to 4.3

    fabpot committed Nov 26, 2018
    Configuration menu
    Copy the full SHA
    534b83f View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2018

  1. Merge branch '4.2'

    * 4.2:
      Update PR template
      Fixes sprintf(): Too few arguments in Translator
      [Cache] fix deps
      updated CHANGELOG for 4.2.0-RC1
      bumped Symfony version to 4.1.9
      updated VERSION for 4.1.8
      updated CHANGELOG for 4.1.8
      bumped Symfony version to 3.4.20
      updated VERSION for 3.4.19
      updated CHANGELOG for 3.4.19
      [Console] Move back root exception to stack trace in verbose mode
    nicolas-grekas committed Nov 27, 2018
    Configuration menu
    Copy the full SHA
    0d35f97 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2018

  1. Merge branch '4.2'

    * 4.2:
      [DI] fix combinatorial explosion when analyzing the service graph
      [Debug] workaround opcache bug mutating "$this" !?!
    nicolas-grekas committed Nov 28, 2018
    Configuration menu
    Copy the full SHA
    e343b66 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2018

  1. Merge branch '4.2'

    * 4.2:
      [Routing] fix trailing slash redirection
      calculate cache keys for property setters depending on the value
      updated VERSION for 2.8.48
      update CONTRIBUTORS for 2.8.48
      updated CHANGELOG for 2.8.48
    nicolas-grekas committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    63c423a View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2018

  1. Merge branch '4.2'

    * 4.2:
      typo
      [Messenger] Mention HandleTrait in UPGRADE-4.2.md file
      add a test case
      [Form] Handle all case variants of "nan" when parsing a number
    nicolas-grekas committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    6da7afc View commit details
    Browse the repository at this point in the history
  2. Merge branch '4.2'

    * 4.2:
      [Routing] fix greediness of trailing slash
      bumped Symfony version to 4.2.1
      updated VERSION for 4.2.0
      updated CHANGELOG for 4.2.0
    nicolas-grekas committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    5ba4997 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2018

  1. Merge branch '4.2'

    * 4.2:
      fix cs
      [FrameworkBundle] define doctrine as default_pdo_provider only if the package is installed
      [Validator] Allow `ConstraintViolation::__toString()` to expose codes that are not null or emtpy strings
      Added upgrade to HandlersLocator
      fix type for $value in DocBlock
      [WebProfilerBundle] Fix title case
      [Config] fix path exclusion during glob discovery
      [FrameworkBundle][Messenger] Restore check for messenger serializer default id
      Fix wrapped loop of event listener
      [DI] fix edge case in InlineServiceDefinitionsPass
      undeprecate the single-colon notation for controllers
      Update HttpKernel.php
    nicolas-grekas committed Dec 1, 2018
    Configuration menu
    Copy the full SHA
    a928d2b View commit details
    Browse the repository at this point in the history
  2. feature symfony#29145 [Workflow] Trigger entered event for subject …

    …entering in the Workflow for the first time (lyrixx)
    
    This PR was merged into the 4.3-dev branch.
    
    Discussion
    ----------
    
    [Workflow] Trigger `entered` event for subject entering in the Workflow for the first time
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | symfony#28319
    | License       | MIT
    | Doc PR        |
    
    Commits
    -------
    
    388840f [Workflow] Trigger `entered` event for subject entering in the Workflow for the first time
    nicolas-grekas committed Dec 1, 2018
    Configuration menu
    Copy the full SHA
    905119b View commit details
    Browse the repository at this point in the history
  3. [DomCrawler] Added return of element name in extract() method

    Andrey Helldar authored and nicolas-grekas committed Dec 1, 2018
    Configuration menu
    Copy the full SHA
    79162c1 View commit details
    Browse the repository at this point in the history
  4. feature symfony#29127 [DomCrawler] Added return of element name in `e…

    …xtract()` method (andrey-helldar)
    
    This PR was squashed before being merged into the 4.3-dev branch (closes symfony#29127).
    
    Discussion
    ----------
    
    [DomCrawler] Added return of element name in `extract()` method
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | License       | MIT
    | Doc PR        | symfony/symfony-docs#10646
    
    Situation: you need to get an array of keys and values.
    The current package code does not allow this to be done easily.
    The changes made to the code will allow you to return the required data set.
    ```php
    use Symfony\Component\DomCrawler\Crawler;
    
    $crawler = new Crawler($content);
    
    $crawler
        ->filter('ItemsList > Item')
        ->each(function (Crawler $element) {
            $data = $element
                ->children()
                ->extract(['_name', '_text']);
    
            var_dump($data);
        });
    
    // Result:
    array:2 [
      0 => array:2 [
        0 => "id",
        1 => "1"
      ],
      1 => array:2 [
        0 => "title",
        1 => "Foo Bar"
      ]
    ]
    ```
    
    Commits
    -------
    
    79162c1 [DomCrawler] Added return of element name in `extract()` method
    nicolas-grekas committed Dec 1, 2018
    Configuration menu
    Copy the full SHA
    4df912b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    aee4e33 View commit details
    Browse the repository at this point in the history
  6. feature symfony#28976 [DI] Add a "default" EnvProcessor (jderusse)

    This PR was squashed before being merged into the 4.3-dev branch (closes symfony#28976).
    
    Discussion
    ----------
    
    [DI] Add a "default" EnvProcessor
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | TODO
    
    This PR add a new fallback env processor in order to return a default value when the primary processor is not able to fetch a value (env variable, file or key does not exists)
    
    ```
    #
    default_host: localhost
    host: '%env(default:default_host:OPTIONAL_ENV_VARIABLE)%"
    
    default_secret: this secret is not secret
    secret: '%env(default:default_secret:file:THIS_FILE_ONLY_EXIST_IN_PRODUCTION)%"
    
    default_charset: utf8
    charset: '%env(default:default_charset:key:charset:json:DATABASE_CONFIG)%"
    ```
    
    Commits
    -------
    
    aee4e33 [DI] Add a \"default\" EnvProcessor
    nicolas-grekas committed Dec 1, 2018
    Configuration menu
    Copy the full SHA
    67be665 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    397c19e View commit details
    Browse the repository at this point in the history
  8. feature symfony#28858 [DI] Deprecated using env vars with cannotBeEmp…

    …ty() (ro0NL)
    
    This PR was squashed before being merged into the 4.3-dev branch (closes symfony#28858).
    
    Discussion
    ----------
    
    [DI] Deprecated using env vars with cannotBeEmpty()
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | yes-ish
    | New feature?  | yes
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | yes
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | symfony#28827
    | License       | MIT
    | Doc PR        | symfony/symfony-docs#... <!-- required for new features -->
    
    Continuation of symfony#28838 for 4.2
    
    Using environment variables for nodes marked `cannotBeEmpty()` is semantically not possible, we'll never know the value is empty yes/no during compile time. Neither we should assume one or another.
    
    Commits
    -------
    
    397c19e [DI] Deprecated using env vars with cannotBeEmpty()
    nicolas-grekas committed Dec 1, 2018
    Configuration menu
    Copy the full SHA
    e695449 View commit details
    Browse the repository at this point in the history
  9. feature symfony#28479 [Validator] Checking a BIC along with an IBAN (…

    …sylfabre)
    
    This PR was merged into the 4.3-dev branch.
    
    Discussion
    ----------
    
    [Validator] Checking a BIC along with an IBAN
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | yes
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | symfony#28166
    | License       | MIT
    | Doc PR        | symfony/symfony-docs#10349
    
    A BIC comes usually with an IBAN so it's better to check that they are associated. This PR provides an `iban` option to `Symfony\Component\Validator\Constraints\Bic` to check the BIC against an IBAN.
    
    It also provides an `ibanPropertyPath` to retrieves the IBAN using the property accessor like with comparison constraints.
    
    Commits
    -------
    
    bb6be15 [Validator] Checking a BIC along with an IBAN Fix symfony#28166
    nicolas-grekas committed Dec 1, 2018
    Configuration menu
    Copy the full SHA
    cc0be40 View commit details
    Browse the repository at this point in the history
  10. Add upgrade from 4.2 to 4.3

    ro0NL committed Dec 1, 2018
    Configuration menu
    Copy the full SHA
    ce6ecaf View commit details
    Browse the repository at this point in the history
  11. Merge branch '4.2'

    * 4.2:
      [DI] fix InlineServiceDefinitionsPass' fix
      [LDAP] Add TIMEOUT Option to LDAP Connection Options
    nicolas-grekas committed Dec 1, 2018
    Configuration menu
    Copy the full SHA
    4cc14b4 View commit details
    Browse the repository at this point in the history
  12. minor symfony#29400 Add upgrade from 4.2 to 4.3 (ro0NL)

    This PR was merged into the 4.3-dev branch.
    
    Discussion
    ----------
    
    Add upgrade from 4.2 to 4.3
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        | symfony/symfony-docs#... <!-- required for new features -->
    
    Forgotten in symfony#28858 i guess. cc @nicolas-grekas
    
    Commits
    -------
    
    ce6ecaf Add upgrade from 4.2 to 4.3
    nicolas-grekas committed Dec 1, 2018
    Configuration menu
    Copy the full SHA
    9771d8d View commit details
    Browse the repository at this point in the history
  13. fix merge

    nicolas-grekas committed Dec 1, 2018
    Configuration menu
    Copy the full SHA
    d63b3e3 View commit details
    Browse the repository at this point in the history
  14. feature symfony#28954 [Debug] Mark ErrorHandler and ExceptionHandler …

    …classes as final (fancyweb)
    
    This PR was merged into the 4.3-dev branch.
    
    Discussion
    ----------
    
    [Debug] Mark ErrorHandler and ExceptionHandler classes as final
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | not yet
    | Deprecations? | yes
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    The goal of marking this method final is to be able to change the argument signature to `\Throwable` in Symfony 5.0
    
    We will then be able to convert the incoming `\Throwable` to `\ErrorException` thanks to the `FatalThrowableError` class.
    
    The use case is when you use the `ExceptionHandler::register()` method of the `Debug` component with a custom `set_error_handler()` that don't handle this conversion. This is for example the case of the `Drupal` one.
    
    Commits
    -------
    
    2a4e2e6 [Debug] Mark the ErrorHandler and ExceptionHandler classes as final
    nicolas-grekas committed Dec 1, 2018
    Configuration menu
    Copy the full SHA
    8aee36d View commit details
    Browse the repository at this point in the history
  15. [DI] Fix deps=low

    ro0NL authored and nicolas-grekas committed Dec 1, 2018
    Configuration menu
    Copy the full SHA
    e0d9502 View commit details
    Browse the repository at this point in the history
  16. minor symfony#29401 [DI] Fix deps=low (ro0NL)

    This PR was squashed before being merged into the 4.3-dev branch (closes symfony#29401).
    
    Discussion
    ----------
    
    [DI] Fix deps=low
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no
    | Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
    | Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
    | License       | MIT
    | Doc PR        | symfony/symfony-docs#... <!-- required for new features -->
    
     cc @nicolas-grekas
    
    Commits
    -------
    
    e0d9502 [DI] Fix deps=low
    nicolas-grekas committed Dec 1, 2018
    Configuration menu
    Copy the full SHA
    0105562 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2018

  1. Merge branch '4.2'

    * 4.2:
      [Serializer] fixed DateTimeNormalizer to maintain microseconds when a different timezone required
      [Routing] fix taking verb into account when redirecting
      [TwigBundle] Sync tab navigation css
      [WebProfilerBundle] Fix log filter in dark mode
      [WebProfilerBundle][4.2] Deny messenger <4.2
      [DI] Fix dumping expressions accessing single-use private services
      [VarExporter] fix dumping protected property from abstract classes
      [WebProfilerBundle] Split form field heading
      Minor tweak for c3ad8a5
    nicolas-grekas committed Dec 2, 2018
    Configuration menu
    Copy the full SHA
    79b661d View commit details
    Browse the repository at this point in the history
  2. Merge branch '4.2'

    * 4.2:
      [DI] dont inline when lazy edges are found
    nicolas-grekas committed Dec 2, 2018
    Configuration menu
    Copy the full SHA
    974b98b View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2018

  1. Merge branch '4.2'

    * 4.2:
      [VarExporter] fix dumping private properties from abstract classes
      Fix empty output for debug:autowiring when reflection-docblock is not available
      [Workflow] Fixed BC break for Workflow metadata
      [Routing] ignore trailing slash for non-GET requests
    nicolas-grekas committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    c7fe1b6 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2018

  1. Merge branch '4.2'

    * 4.2:
      [TwigBridge] Deprecating legacy Twig paths in DebugCommand and simplifications
      [Cache] Fixed Memcached adapter doClear()to call flush()
      Fixes sprintf(): Too few arguments in Translator
      fix TransChoiceTokenParser deprecation message
      [DoctrineBridge] Conflict with Messenger <4.2
      [Contracts] extract LocaleAwareInterface out of TranslatorInterface
    nicolas-grekas committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    e6fa538 View commit details
    Browse the repository at this point in the history
  2. Avoid multiple rendering of collection prototypes

     A collection prototype that has already been rendered shouldn't be rendered again as this is deprecated since Symfony 4.2
    kagje committed Dec 6, 2018
    Configuration menu
    Copy the full SHA
    7011706 View commit details
    Browse the repository at this point in the history