[DI] fix dumping inlined services #29104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0NL
approved these changes
Nov 6, 2018
nicolas-grekas
force-pushed
the
di-fix-28824
branch
from
ec05653
to
a97606d
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Nov 6, 2018
This PR was merged into the 3.4 branch. Discussion ---------- [DI] fix dumping inlined services | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28824 #29078 | License | MIT | Doc PR | - Same as #29103 but for 3.4. This PR dump inline services using the call-stack to sort the code for instantiating them. This makes easier to follow and matches the behavior one would expect (and has when using `ContainerBuiler` directly to create services.) Commits ------- a97606d [DI] fix dumping inlined services
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #29103 but for 3.4.
This PR dump inline services using the call-stack to sort the code for instantiating them.
This makes easier to follow and matches the behavior one would expect (and has when using
ContainerBuilerdirectly to create services.)