Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] Support use of hyphen in assets package name #28128

Closed
wants to merge 2 commits into from

Commits on Aug 3, 2018

  1. Update Configuration.php

    Support for using hyphens on yaml config for packages names, according to issue symfony#28122 (comment)
    damaya committed Aug 3, 2018
    Configuration menu
    Copy the full SHA
    83a72a0 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2018

  1. symfony#28122 Support use of hyphen in asset package name

    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no     <!-- see https://symfony.com/bc -->
    | Deprecations? | no
    | Tests pass?   | yes (Manual tests only)
    | Fixed tickets | symfony#28122
    | License       | MIT
    | Doc PR        | n/a
    
    According to issue symfony/symfony-docs#10442, we tested in a demo bundle, for example in src/AppBundle/Resources/config/config.yml a package using hyphens: app-client-frontend, and withouth the patch it fails because the package is not recognized. With the patch, it works as expected.
    ```
    framework:
        assets:
            packages:
                app-client-frontend:
                    version: "%env(FRONTEND_VERSION)%"
                    version_format: '%%2$s/dist/%%1$s'
                    base_urls:
                      - "%env(FRONTEND_URL)%"
    ```
    damaya committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    8fd99e2 View commit details
    Browse the repository at this point in the history