[FrameworkBundle] Fix wrong returned status code in ConfigDebugCommand #33805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Oct 2, 2019
xabbuh
approved these changes
Oct 2, 2019
|
Thank you Jan. |
xabbuh
added a commit
that referenced
this pull request
Oct 2, 2019
…DebugCommand (jschaedl) This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle] Fix wrong returned status code in ConfigDebugCommand | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #33747<!-- prefix each issue number with "Fix #", if any --> | License | MIT | Doc PR | - This is a follow-up PR caused by #33775 (comment) Commits ------- 9b5ced2 [FrameworkBundle] Fix wrong returned status code in ConfigDebugCommand
1 task
nicolas-grekas
added a commit
that referenced
this pull request
Oct 2, 2019
…ling Command::execute() (jschaedl) This PR was merged into the 5.0-dev branch. Discussion ---------- [Console] Throw a TypeError for non-int return value calling Command::execute() | Q | A | ------------- | --- | Branch? | 5.0 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | yes <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #33747 <!-- prefix each issue number with "Fix #", if any --> | License | MIT | Doc PR | - <!-- required for new features --> ### Todo - [x] needs to be rebased after 4.4 was merged into master (see: #33805) Commits ------- b3a3b0c [Console] Throw a TypeError for non-int return values on calling Command::execute()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR caused by #33775 (comment)