[Validator] Added support for validation of giga values #32485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaznovac
reviewed
Jul 11, 2019
| @@ -104,6 +104,8 @@ private function normalizeBinaryFormat($maxSize) | |||
| 'ki' => 1 << 10, | |||
| 'm' => 1000000, | |||
| 'mi' => 1 << 20, | |||
| 'g' => 1000000000, | |||
There was a problem hiding this comment.
i'd rather use constant expression as it is easier to see that the value is correct
Suggested change
| 'g' => 1000000000, | |
| 'g' => 1000 * 1000 * 1000, |
There was a problem hiding this comment.
Great idea. Could you add the change for 'm' as well?
There was a problem hiding this comment.
as this is a bugfix it's advisable to leave it for the next commit
if you want to change it (i certainly like code consistency) this is the line:
'm' => 1000 * 1000,
|
@derrabus ok, i'll try to setup a testing environment for it but it will take a few days, probably. |
nicolas-grekas
changed the title
nicolas-grekas
requested changes
Jul 18, 2019
|
@nicolas-grekas |
nicolas-grekas
approved these changes
Jul 19, 2019
fabpot
approved these changes
Jul 19, 2019
|
Thank you @kernig. |
fabpot
added a commit
that referenced
this pull request
Jul 19, 2019
…ernig) This PR was squashed before being merged into the 3.4 branch (closes #32485). Discussion ---------- [Validator] Added support for validation of giga values As described in issue #32479 | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | just tested on my presta and it works. if further tests are necessary, it would be great if someone could help! | Fixed tickets | #32479 | License | MIT | Doc PR | The validation(function normalizeBinaryFormat) in symfony/src/Symfony/Component/Validator/Constraints/File.php doesn't work with gigabyte values in php.ini. In the PHP documentation it says "PHP allows shortcuts for byte values, including K (kilo), M (mega) and G (giga). " so in my opinion these values should work. Thanks to @kijamve for the fix. Commits ------- 969f2c4 [Validator] Added support for validation of giga values
This was referenced Jul 27, 2019
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in issue #32479
The validation(function normalizeBinaryFormat) in symfony/src/Symfony/Component/Validator/Constraints/File.php doesn't work with gigabyte values in php.ini.
In the PHP documentation it says "PHP allows shortcuts for byte values, including K (kilo), M (mega) and G (giga). " so in my opinion these values should work.
Thanks to @kijamve for the fix.