[PhpUnitBridge] PHPUnit 8 incompatibility

[evertharmeling]

Symfony version(s) affected: 4.2.x (but probably all PHP<7.0 compatible versions too)

Description
Using the symfony/testpack, symfony/phpunit-bridge and setting the phpunit version on 8.0. When creating a test which extends Symfony\Bundle\FrameworkBundle\Test\KernelTestCase it will throw the following error:

PHP Fatal error:  Declaration of Symfony\Bundle\FrameworkBundle\Test\KernelTestCase::tearDown() must be compatible with PHPUnit\Framework\TestCase::tearDown(): void in /projects/phpunit-8/vendor/symfony/framework-bundle/Test/KernelTestCase.php on line 24

How to reproduce

https://github.com/evertharmeling/symfony-phpunit-8

Using the 'reproducer' project:

• Run composer install in project root.
• Run vendor/bin/simple-phpunit in project root.

Possible Solution

• Restricting the phpunit/phpunit version to <8.0

Additional context

Somewhat related #14736. Because this could solve for support on phpunit >=8.0

[alexander-schranz]

Another solution could be using class_alias: see #30084

[evertharmeling]

#30124

[xabbuh]

I think we can close here now that the related PRs were merged.

[mente]

Wasn't #30124 merged only into 3.4 branch only? This bug report is about 4.2

[xabbuh]

We regularly merge lower branches up into branches for all still maintained Symfony versions. So the bugfix will also be part of the next 4.2 patch release.

[garak]

What about other Symfony tests?
For example, https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Form/Test/FormIntegrationTestCase.php is still missing the void return type, so extending it to test a form is not working.
Doing a quick search (just a grep -r 'function setUp()' vendor/symfony/ | grep Test), I can find 208 occurrences of setUp method, all without void return type.

[nicolas-grekas]

@garak There should be two distinct approaches. One for Test namespaces, another for the internal Tests ones. Would you mind sending a PR for the first case, following what's been done for KernelTestCase?

[garak]

@nicolas-grekas I'd be glad to propose a PR, but I'm afraid I'm a bit lost... I tried to search in related issues and PRs and only found something related to tearDown, nothing about setUp.
Can you point me in the right direction? Thanks

[nicolas-grekas]

I think the same strategy as https://github.com/symfony/symfony/blob/master/src/Symfony/Bundle/FrameworkBundle/Test/KernelShutdownOnTearDownTrait.php could work for setUp too. I didn't have a better look so can't be more specific sorry.

[garak]

But in this case the content of setUp is not the same, duplicating it with eval looks a bit cumbersome to me. What if a target a PR to 4.2 branch instead?

[nicolas-grekas]

Adding void on 4.2 would immediately break all CI that don't use phpunit8 yet. No go.

[StevenCarre]

How can I restrict php-unit version to <8.0?

[evertharmeling]

@StevenCarre when using PhpUnitBridge with https://github.com/evertharmeling/symfony-phpunit-8/blob/master/phpunit.xml.dist#L14

[StevenCarre]

thank you. Can you tell me where this file is located please?

[evertharmeling]

You can place the xml configuration file where you want, but you have to point to the configuration file when running (simple-)phpunit, like bin/simple-phpunit -c /path/to/phpunit.xml.dist.

See https://phpunit.readthedocs.io/en/8.1/textui.html and https://phpunit.readthedocs.io/en/8.1/configuration.html

[mrtnzagustin]

Hi there, i have a problem when executing ./vendor/bin/simple-phpunit in a docker testing stage container. Each time i make a build, test are slow cause simple-phpunit dowload phpunit. How can i download it with other command to mantain it in cache?

[nicolas-grekas]

you should run ./vendor/bin/simple-phpunit install just after composer install, when building the image.

[mrtnzagustin]

@nicolas-grekas , thanks. I've installed phpunit with that command. The problem is when i run RUN ./vendor/bin/simple-phpunit after the installation, load of fixtures, etc. The output is:

Looks like simple-phpunit is not detecting the installation itself, try to install and fail cause the folder already exists.

[mrtnzagustin]

In addition, trying setting version in phpunit.xml.dist, and the ./vendor/bin/simple-phpunit install dont use that version. When the test are executed with ./vendor/bin/simple-phpunit, the script install the version in the file.

[mrtnzagustin]

The problem vanish when i use a single line to copy the entire app and just one composer install:

RUN composer install
COPY [".", "/var/www/"]
RUN ./vendor/bin/simple-phpunit install

# Crea la base de datos y la carga con fixtures
RUN php bin/console doctrine:database:create --env=test --no-debug
RUN php bin/console doctrine:schema:update --env=test --force --no-debug
RUN php bin/console hautelook:fixtures:load --env=test

# Ejecuta testing
RUN ./vendor/bin/simple-phpunit

but error in test execution when i do this:

# Copia solo dependencias y las instala
COPY composer.json composer.json
COPY composer.lock composer.lock
COPY symfony.lock symfony.lock
RUN composer install --prefer-dist --no-scripts --no-autoloader && rm -rf /root/.composer
RUN ./vendor/bin/simple-phpunit install 

# Copia el codigo fuente a donde corresponde dentro del contenedor
COPY [".", "/var/www/"]

# Finish composer
RUN composer dump-autoload --no-scripts --optimize

# Crea la base de datos y la carga con fixtures
RUN php bin/console doctrine:database:create --env=test --no-debug
RUN php bin/console doctrine:schema:update --env=test --force --no-debug
RUN php bin/console hautelook:fixtures:load --env=test

# Ejecuta testing
RUN ./vendor/bin/simple-phpunit

[enriquerene]

I replaced function setUp () by function setUp (): void and worked for me (PHPUnit 8, Synfony 5.1).

[StevenCarre]

@enriquerene one year later thanks, it worked for me too. Cheers