Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filesystem] FilesystemTestCase is not compatible with PHPUnit 8 #30695

Closed
GaryPEGEOT opened this issue Mar 25, 2019 · 4 comments
Closed

[Filesystem] FilesystemTestCase is not compatible with PHPUnit 8 #30695

GaryPEGEOT opened this issue Mar 25, 2019 · 4 comments

Comments

@GaryPEGEOT
Copy link
Contributor

GaryPEGEOT commented Mar 25, 2019

Symfony version(s) affected: >= 3.4

Description
the FilesystemTestCase has the same issue that #30071

How to reproduce
Run a test extending FilesystemTestCase with PHPUnit 8 will produce:
PHP Fatal error: Declaration of Symfony\Component\Filesystem\Tests\FilesystemTestCase::setUpBeforeClass() must be compatible with PHPUnit\Framework\TestCase::setUpBeforeClass(): void

Possible Solution
Use the same solution that #30474

@dmaicher
Copy link
Contributor

Is this a test class that is meant to be used in userland code? I mean a lot of internal Symfony tests are not PHPUnit 8 compatible.

@GaryPEGEOT
Copy link
Contributor Author

Not sure in fact... but it's not marked as internal

@xabbuh
Copy link
Member

xabbuh commented Mar 26, 2019

All classes from the Tests namespaces are purely internal code and you should never rely on any of them.

@chalasr
Copy link
Member

chalasr commented Mar 26, 2019

Closing as explained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants