Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Form] UrlType should be text when default_protocol is set #29690

Closed
MatTheCat opened this issue Dec 26, 2018 · 1 comment
Closed

[Form] UrlType should be text when default_protocol is set #29690

MatTheCat opened this issue Dec 26, 2018 · 1 comment
Labels
Bug Form Status: Needs Review

Comments

@MatTheCat
Copy link
Contributor

MatTheCat commented Dec 26, 2018 •
edited

Symfony version(s) affected: all

Description

https://html.spec.whatwg.org/multipage/input.html#url-state-(type=url)

The input element represents a control for editing a single absolute URL given in the element's value.

That means default_protocol is useless because its purpose concerns invalid values.

How to reproduce

Display a UrlType field.

Possible Solution

input type should be text when default_protocol is not null and url inputmode should be added.
@MatTheCat MatTheCat mentioned this issue Dec 26, 2018
Closed
@xabbuh xabbuh added the Bug label Dec 28, 2018
@xabbuh xabbuh mentioned this issue Jan 18, 2019
Merged
@xabbuh
Copy link
Member

xabbuh commented Jan 23, 2019

I am reopening here as the linked PR isn't merged yet.

@xabbuh xabbuh reopened this Jan 23, 2019
nicolas-grekas added a commit that referenced this issue Jan 25, 2019
@nicolas-grekas
bug #29926 [Form] Changed UrlType input type to text when default_pro…
e3b010f 
…tocol is not null (MatTheCat)

This PR was merged into the 3.4 branch.

Discussion
----------

[Form] Changed UrlType input type to text when default_protocol is not null

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29690
| License       | MIT
| Doc PR        |

replaces #29691

Commits
-------

2791edf [Form] Changed UrlType input type to text when default_protocol is not null
@j0k3r j0k3r mentioned this issue Feb 8, 2019
Merged
@lmlsna lmlsna mentioned this issue Apr 27, 2019
Closed
@MatTheCat MatTheCat mentioned this issue Apr 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Form Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@javiereguiluz @nicolas-grekas @MatTheCat @xabbuh @carsonbot