Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI][4.2] It's a requirement to specify a Metadata Driver and pass it to Doctrine\ORM\Configuration::setMetadataDriverImpl(). #29078

Closed
ro0NL opened this issue Nov 4, 2018 · 4 comments

Comments

@ro0NL
Copy link
Contributor

ro0NL commented Nov 4, 2018

Symfony version(s) affected: 4.2

This is another report of #28304

The reproducing app is at https://github.com/ro0NL/sf

Running git apply patch.diff && composer install (to downgrade to 4.1) solves it.

EDIT: if you still have this issue, running composer require symfony/proxy-manager-bridge should fix it.

@ro0NL
Copy link
Contributor Author

ro0NL commented Nov 4, 2018

So, the weird thing is it only happens during initial container building (or cache:clear)

@nicolas-grekas
Copy link
Member

Should be fixed in #29103

nicolas-grekas added a commit that referenced this issue Nov 6, 2018
This PR was merged into the 3.4 branch.

Discussion
----------

[DI] fix dumping inlined services

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #28824 #29078
| License       | MIT
| Doc PR        | -

Same as #29103 but for 3.4.

This PR dump inline services using the call-stack to sort the code for instantiating them.
This makes easier to follow and matches the behavior one would expect (and has when using `ContainerBuiler` directly to create services.)

Commits
-------

a97606d [DI] fix dumping inlined services
@nicolas-grekas
Copy link
Member

(now merged up to master, should be easier to test)

@ro0NL
Copy link
Contributor Author

ro0NL commented Nov 8, 2018

all good 👍

nicolas-grekas added a commit that referenced this issue Nov 20, 2018
…e container (nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[DI] fix taking lazy services into account when dumping the container

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29246
| License       | MIT
| Doc PR        | -

This PR fixes issues found while working on #29246.
It *does* fix the infinite loop, ~but replaces it by an exception (reopening #29078)~:
> ~It's a requirement to specify a Metadata Driver and pass it to Doctrine\ORM\Configuration::setMetadataDriverImpl()~

The full fix is not immediately accessible as it needs some core changes to the dumping logic. Requiring `symfony/proxy-manager-bridge` works around the issue properly.

See #29251 for 4.2

Commits
-------

67d7623 [DI] fix taking lazy services into account when dumping the container
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants