Skip to content

Commit

Permalink
minor #39975 [Serializer] Fix tests wrongly marked as incomplete (cha…
Browse files Browse the repository at this point in the history
…lasr)

This PR was merged into the 4.4 branch.

Discussion
----------

[Serializer] Fix tests wrongly marked as incomplete

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

#30907 has been merged meanwhile.

Commits
-------

e632302 [Serializer] Fix tests  marked as incomplete
  • Loading branch information
nicolas-grekas committed Jan 26, 2021
2 parents 4b8983a + e632302 commit ffdc46c
Showing 1 changed file with 0 additions and 2 deletions.
Expand Up @@ -38,8 +38,6 @@ public function testIgnoredAttributesNormalize()
$normalizer->normalize($objectOuter, null, $context)
);

$this->markTestIncomplete('AbstractObjectNormalizer::getAttributes caches attributes by class instead of by class+context, reusing the normalizer with different config therefore fails. This is being fixed in https://github.com/symfony/symfony/pull/30907');

$context = ['ignored_attributes' => ['foo', 'inner']];
$this->assertEquals(
[
Expand Down

0 comments on commit ffdc46c

Please sign in to comment.