Fix the translation commands when a template contains a syntax error

symfony · Nov 29, 2019 · f63e843 · f63e843
1 parent fa783f9
commit f63e843
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/TranslationDebugCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/TranslationDebugCommand.php
@@ -204,7 +204,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
         }
 
         // Extract used messages
-        $extractedCatalogue = $this->extractMessages($locale, $viewsPaths);
+        $extractedCatalogue = $this->extractMessages($io->getErrorStyle(), $locale, $viewsPaths);
 
         // Load defined messages
         $currentCatalogue = $this->loadCurrentMessages($locale, $transPaths);
@@ -330,12 +330,16 @@ private function sanitizeString($string, $length = 40)
      *
      * @return MessageCatalogue
      */
-    private function extractMessages($locale, $transPaths)
+    private function extractMessages(SymfonyStyle $errorIo, $locale, $transPaths)
     {
         $extractedCatalogue = new MessageCatalogue($locale);
         foreach ($transPaths as $path) {
             if (is_dir($path)) {
-                $this->extractor->extract($path, $extractedCatalogue);
+                try {
+                    $this->extractor->extract($path, $extractedCatalogue);
+                } catch (\Exception $e) {
+                    $errorIo->warning($e->getMessage());
+                }
             }
         }
 

diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/TranslationUpdateCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/TranslationUpdateCommand.php
@@ -215,7 +215,11 @@ protected function execute(InputInterface $input, OutputInterface $output)
         $this->extractor->setPrefix($prefix);
         foreach ($viewsPaths as $path) {
             if (is_dir($path)) {
-                $this->extractor->extract($path, $extractedCatalogue);
+                try {
+                    $this->extractor->extract($path, $extractedCatalogue);
+                } catch (\Exception $e) {
+                    $errorIo->warning($e->getMessage());
+                }
             }
         }