Skip to content

Commit

Permalink
bug #30361 [PropertyInfo] Fix undefined variable fromConstructor when…
Browse files Browse the repository at this point in the history
… passing context to getTypes (mantis)

This PR was merged into the 4.2 branch.

Discussion
----------

[PropertyInfo] Fix undefined variable fromConstructor when passing context to getTypes

| Q             | A
| ------------- | ---
| Branch?       | 4.1, 4.2, master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | symfony/symfony-docs#10969
| License       | MIT
| Doc PR        |

If passing context to getTypes, it checks value of $context['enable_constructor_extraction'] for true/false or the constructor value of enableConstructorExtraction and should then populate fromConstructor if necessary. The missing brackets around the first part of this check mean that fromConstructor is only applied if context is not set.

This fixes the issue described at [symfony/symfony-docs#10969](symfony/symfony-docs#10969)

Commits
-------

7e4abee Fix undefined variable fromConstructor when passing context to getTypes
  • Loading branch information
fabpot committed Mar 5, 2019
2 parents af52f6e + 7e4abee commit e74e0f9
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit e74e0f9

Please sign in to comment.