Skip to content

Commit

Permalink
bug #33282 [HttpKernel] Do not extend the new SF 4.3 ControllerEvent …
Browse files Browse the repository at this point in the history
…so we can make it final (Tobion)

This PR was merged into the 4.3 branch.

Discussion
----------

[HttpKernel] Do not extend the new SF 4.3 ControllerEvent so we can make it final

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | unlikely
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets |
| License       | MIT
| Doc PR        |

See #33152 (comment)
Remember the ControllerEvent is new in SF 4.3 so we just go back to what it was before 4.3

Commits
-------

00140b6 Do not extend the new SF 4.3 ControllerEvent so we can make it final
  • Loading branch information
nicolas-grekas committed Aug 21, 2019
2 parents 72eaff8 + 00140b6 commit dd153d8
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
/**
* @deprecated since Symfony 4.3, use ControllerArgumentsEvent instead
*/
class FilterControllerArgumentsEvent extends ControllerEvent
class FilterControllerArgumentsEvent extends FilterControllerEvent
{
private $arguments;

Expand Down

0 comments on commit dd153d8

Please sign in to comment.