Skip to content

Commit

Permalink
minor #29611 Adjust tests to work in the armhf architecture. Fixes #2…
Browse files Browse the repository at this point in the history
…9281. (panlinux)

This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #29611).

Discussion
----------

Adjust tests to work in the armhf architecture. Fixes #29281.

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | can't verify
| Fixed tickets | #29281
| License       | MIT

We saw VarDumper errors in armhf, but they are hard to reproduce interactively. In the issue report, it was suggested to replace %d with %i, and that's what I did in this branch. I'm sorry I can't give you confidence that this fixes the issue, and I'm just filing this PR because it was suggested and I'm trying to be helpful. I'm hoping there is CI here that can verify it.

Commits
-------

b9359a5 Adjust tests to work in the armhf architecture. Fixes #29281.
  • Loading branch information
nicolas-grekas committed Dec 14, 2018
2 parents fac85a1 + b9359a5 commit d1bf595
Showing 1 changed file with 3 additions and 3 deletions.
Expand Up @@ -35,7 +35,7 @@ public function getCastFileInfoTests()
aTime: %s-%s-%d %d:%d:%d
mTime: %s-%s-%d %d:%d:%d
cTime: %s-%s-%d %d:%d:%d
inode: %d
inode: %i
size: %d
perms: 0%d
owner: %d
Expand Down Expand Up @@ -85,7 +85,7 @@ public function testCastFileObject()
aTime: %s-%s-%d %d:%d:%d
mTime: %s-%s-%d %d:%d:%d
cTime: %s-%s-%d %d:%d:%d
inode: %d
inode: %i
size: %d
perms: 0%d
owner: %d
Expand All @@ -105,7 +105,7 @@ public function testCastFileObject()
maxLineLen: 0
fstat: array:26 [
"dev" => %d
"ino" => %d
"ino" => %i
"nlink" => %d
"rdev" => 0
"blksize" => %i
Expand Down

0 comments on commit d1bf595

Please sign in to comment.