Skip to content

Commit

Permalink
make do* methods private
Browse files Browse the repository at this point in the history
  • Loading branch information
garak committed Mar 7, 2019
1 parent feb08d8 commit c7c4ca1
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 13 deletions.
Expand Up @@ -27,7 +27,7 @@ abstract class FormIntegrationTestCase extends TestCase
*/
protected $factory;

protected function doSetUp()
private function doSetUp()
{
$this->factory = Forms::createFormFactoryBuilder()
->addExtensions($this->getExtensions())
Expand Down
Expand Up @@ -24,11 +24,11 @@
*/
trait TestCaseSetUpTearDownTrait
{
protected function doSetUp(): void
private function doSetUp(): void
{
}
protected function doTearDown(): void
private function doTearDown(): void
{
}
Expand All @@ -52,14 +52,14 @@ trait TestCaseSetUpTearDownTrait
/**
* @return void
*/
protected function doSetUp()
private function doSetUp()
{
}

/**
* @return void
*/
protected function doTearDown()
private function doTearDown()
{
}

Expand Down
4 changes: 2 additions & 2 deletions src/Symfony/Component/Form/Test/TypeTestCase.php
Expand Up @@ -29,15 +29,15 @@ abstract class TypeTestCase extends FormIntegrationTestCase
*/
protected $dispatcher;

protected function doSetUp()
private function doSetUp()
{
parent::setUp();

$this->dispatcher = $this->getMockBuilder('Symfony\Component\EventDispatcher\EventDispatcherInterface')->getMock();
$this->builder = new FormBuilder('', null, $this->dispatcher, $this->factory);
}

protected function doTearDown()
private function doTearDown()
{
if (\in_array(ValidatorExtensionTrait::class, class_uses($this))) {
$this->validator = null;
Expand Down
Expand Up @@ -50,7 +50,7 @@ abstract class ConstraintValidatorTestCase extends TestCase
protected $constraint;
protected $defaultTimezone;

protected function doSetUp()
private function doSetUp()
{
$this->group = 'MyGroup';
$this->metadata = null;
Expand All @@ -72,7 +72,7 @@ protected function doSetUp()
$this->setDefaultTimezone('UTC');
}

protected function doTearDown()
private function doTearDown()
{
$this->restoreDefaultTimezone();
}
Expand Down
Expand Up @@ -24,11 +24,11 @@
*/
trait TestCaseSetUpTearDownTrait
{
protected function doSetUp(): void
private function doSetUp(): void
{
}
protected function doTearDown(): void
private function doTearDown(): void
{
}
Expand All @@ -52,14 +52,14 @@ trait TestCaseSetUpTearDownTrait
/**
* @return void
*/
protected function doSetUp()
private function doSetUp()
{
}

/**
* @return void
*/
protected function doTearDown()
private function doTearDown()
{
}

Expand Down

0 comments on commit c7c4ca1

Please sign in to comment.