Skip to content

Commit

Permalink
bug #32164 [EventDispatcher] collect called listeners information onl…
Browse files Browse the repository at this point in the history
…y once (xabbuh)

This PR was merged into the 3.4 branch.

Discussion
----------

[EventDispatcher] collect called listeners information only once

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

2ad32df collect called listeners information only once
  • Loading branch information
fabpot committed Jun 26, 2019
2 parents 7cc4cab + 2ad32df commit c511e46
Showing 1 changed file with 9 additions and 12 deletions.
Expand Up @@ -191,21 +191,18 @@ public function getNotCalledListeners()
return [];
}

$calledListeners = [];

if (null !== $this->callStack) {
foreach ($this->callStack as $calledListener) {
$calledListeners[] = $calledListener->getWrappedListener();
}
}

$notCalled = [];
foreach ($allListeners as $eventName => $listeners) {
foreach ($listeners as $listener) {
$called = false;
if (null !== $this->callStack) {
foreach ($this->callStack as $calledListener) {
if ($calledListener->getWrappedListener() === $listener) {
$called = true;

break;
}
}
}

if (!$called) {
if (!\in_array($listener, $calledListeners, true)) {
if (!$listener instanceof WrappedListener) {
$listener = new WrappedListener($listener, null, $this->stopwatch, $this);
}
Expand Down

0 comments on commit c511e46

Please sign in to comment.