Skip to content

Commit

Permalink
minor #30112 Remove "internal" annotation from datacollector serializ…
Browse files Browse the repository at this point in the history
…ation methods (nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

Remove "internal" annotation from datacollector serialization methods

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

I've been a bit too aggressively adding `@internal` in #30035.

Commits
-------

3c8fd20 Remove "internal" annotation from datacollector serialization methods
  • Loading branch information
nicolas-grekas committed Feb 8, 2019
2 parents f331c54 + 3c8fd20 commit bb54e40
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 15 deletions.
Expand Up @@ -228,9 +228,6 @@ public function getData()
return $this->data;
}

/**
* @internal
*/
public function serialize()
{
if ($this->hasVarDumper) {
Expand Down
Expand Up @@ -40,9 +40,6 @@ abstract class DataCollector implements DataCollectorInterface, \Serializable
*/
private $cloner;

/**
* @internal
*/
public function serialize()
{
$trace = debug_backtrace(DEBUG_BACKTRACE_PROVIDE_OBJECT, 2);
Expand All @@ -51,9 +48,6 @@ public function serialize()
return $isCalledFromOverridingMethod ? $this->data : serialize($this->data);
}

/**
* @internal
*/
public function unserialize($data)
{
$this->data = \is_array($data) ? $data : unserialize($data);
Expand Down
Expand Up @@ -176,9 +176,6 @@ public function reset()
$this->clonesIndex = 0;
}

/**
* @internal
*/
public function serialize()
{
if ($this->clonesCount !== $this->clonesIndex) {
Expand All @@ -198,9 +195,6 @@ public function serialize()
return $ser;
}

/**
* @internal
*/
public function unserialize($data)
{
$this->data = unserialize($data);
Expand Down

0 comments on commit bb54e40

Please sign in to comment.