Skip to content

Commit

Permalink
minor #30923 [BrowserKit vs HttpFoundation][TestSuite]Run test in sep…
Browse files Browse the repository at this point in the history
…arate process (greg0ire)

This PR was merged into the 3.4 branch.

Discussion
----------

[BrowserKit vs HttpFoundation][TestSuite]Run test in separate process

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

This test calls code that defines some environment variables, which in
turn trigger the registration of a the deprecation error handler, which
causes unexpected issues when testing other components.

Commits
-------

6d51a04 Run test in separate process
  • Loading branch information
fabpot committed Apr 7, 2019
2 parents 98f26cb + 6d51a04 commit adb15a0
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/Symfony/Component/BrowserKit/Tests/ClientTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -621,6 +621,9 @@ public function testRestart()
$this->assertEquals([], $client->getCookieJar()->all(), '->restart() clears the cookies');
}

/**
* @runInSeparateProcess
*/
public function testInsulatedRequests()
{
$client = new TestClient();
Expand Down

0 comments on commit adb15a0

Please sign in to comment.