Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
bug #34649 more robust initialization from request (dbu)
This PR was merged into the 3.4 branch. Discussion ---------- more robust initialization from request Request::getPort is declared as int|string but can actually return null. | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - I discovered this problem with a functional test where i dispatch the RequestEvent with a `new Request()`. This used to work in symfony 4 and now triggers an error `Argument 1 passed to Symfony\Component\Routing\RequestContext::setHttpPort() must be of the type int, null given` In regular web requests, this should probably never happen, but it seems to me if Request is not robust, the RequestContext should be robust about it. Commits ------- c6ed0f0 more robust initialization from request
- Loading branch information