Skip to content

Commit

Permalink
minor #31424 Fix tests (fabpot)
Browse files Browse the repository at this point in the history
This PR was merged into the 3.4 branch.

Discussion
----------

Fix tests

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

As per https://www.patreon.com/posts/ubuntu-14-04-lts-26560500, Ondej's PPA does not support older versions of PHP anymore and so libsodium is now installed by Ubuntu directly, but the version is too old for PHP.

To make the tests pass again, I've removed libsodium from older versions of PHP and removed HHVM in the matrix as the tests do not pass for an obscure reason (no output); don't want to investigate what it could be.

<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Commits
-------

6b63603 fixed tests
  • Loading branch information
fabpot committed May 8, 2019
2 parents 75d1dd4 + 6b63603 commit 995910a
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,6 @@ env:

matrix:
include:
- php: hhvm-3.18
sudo: required
group: edge
- php: 5.5
env: php_extra="5.6 7.0 7.1"
- php: 7.2
Expand Down Expand Up @@ -181,12 +178,6 @@ before_install:
[[ -e $ext_cache ]] || (tfold ext.symfony_debug "cd src/Symfony/Component/Debug/Resources/ext && phpize && ./configure && make && mv modules/symfony_debug.so $ext_cache && phpize --clean")
echo extension = $ext_cache >> $INI
elif [[ $PHP = 7.* ]]; then
if ! php --ri sodium > /dev/null; then
# install libsodium
sudo apt-get install libsodium-dev -y
tfold ext.libsodium tpecl libsodium sodium.so $INI
fi
tfold ext.apcu tpecl apcu-5.1.16 apcu.so $INI
tfold ext.mongodb tpecl mongodb-1.6.0alpha1 mongodb.so $INI
fi
Expand Down

0 comments on commit 995910a

Please sign in to comment.