minor #32914 [Console] Fix tests not executed (jderusse)

This PR was merged into the 3.4 branch. Discussion ---------- [Console] Fix tests not executed | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | NA | License | MIT | Doc PR | NA Commits ------- bfd5d4e Fix tests on console
symfony · Aug 3, 2019 · 8f87a85 · 8f87a85
2 parents 9188261 + bfd5d4e
commit 8f87a85
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 14 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -299,7 +299,7 @@ install:
               tfold src/Symfony/Component/Console.tty $PHPUNIT src/Symfony/Component/Console --group tty
               if [[ $PHP = ${MIN_PHP%.*} ]]; then
                   export PHP=$MIN_PHP
-                  echo -e "1\\n0" | xargs -I{} bash -c "tfold src/Symfony/Component/Process.sigchild{} SYMFONY_DEPRECATIONS_HELPER=weak ENHANCE_SIGCHLD={} php-$MIN_PHP/sapi/cli/php .phpunit/phpunit-4.8-0/phpunit --colors=always src/Symfony/Component/Process/"
+                  echo -e "1\\n0" | xargs -I{} bash -c "tfold src/Symfony/Component/Process.sigchild{} SYMFONY_DEPRECATIONS_HELPER=weak ENHANCE_SIGCHLD={} php-$MIN_PHP/sapi/cli/php .phpunit/phpunit-4.8-1/phpunit --colors=always src/Symfony/Component/Process/"
               fi
           fi
       }

diff --git a/src/Symfony/Component/Console/Tests/ApplicationTest.php b/src/Symfony/Component/Console/Tests/ApplicationTest.php
@@ -171,6 +171,7 @@ public function testRegisterAmbiguous()
         };
 
         $application = new Application();
+        $application->setAutoExit(false);
         $application
             ->register('test-foo')
             ->setAliases(['test'])

diff --git a/src/Symfony/Component/Console/Tests/Helper/TableTest.php b/src/Symfony/Component/Console/Tests/Helper/TableTest.php
@@ -114,11 +114,11 @@ public function renderProvider()
                 $books,
                 'compact',
 <<<'TABLE'
- ISBN          Title                    Author
- 99921-58-10-7 Divine Comedy            Dante Alighieri
- 9971-5-0210-0 A Tale of Two Cities     Charles Dickens
- 960-425-059-0 The Lord of the Rings    J. R. R. Tolkien
- 80-902734-1-6 And Then There Were None Agatha Christie
+ ISBN          Title                    Author           
+ 99921-58-10-7 Divine Comedy            Dante Alighieri  
+ 9971-5-0210-0 A Tale of Two Cities     Charles Dickens  
+ 960-425-059-0 The Lord of the Rings    J. R. R. Tolkien 
+ 80-902734-1-6 And Then There Were None Agatha Christie  
 
 TABLE
             ],
@@ -127,14 +127,14 @@ public function renderProvider()
                 $books,
                 'borderless',
 <<<'TABLE'
- =============== ========================== ==================
-  ISBN            Title                      Author
- =============== ========================== ==================
-  99921-58-10-7   Divine Comedy              Dante Alighieri
-  9971-5-0210-0   A Tale of Two Cities       Charles Dickens
-  960-425-059-0   The Lord of the Rings      J. R. R. Tolkien
-  80-902734-1-6   And Then There Were None   Agatha Christie
- =============== ========================== ==================
+ =============== ========================== ================== 
+  ISBN            Title                      Author            
+ =============== ========================== ================== 
+  99921-58-10-7   Divine Comedy              Dante Alighieri   
+  9971-5-0210-0   A Tale of Two Cities       Charles Dickens   
+  960-425-059-0   The Lord of the Rings      J. R. R. Tolkien  
+  80-902734-1-6   And Then There Were None   Agatha Christie   
+ =============== ========================== ================== 
 
 TABLE
             ],