Skip to content

Commit

Permalink
minor #29408 [Security] getTargetPath of TargetPathTrait must return …
Browse files Browse the repository at this point in the history
…string or null (gmponos)

This PR was squashed before being merged into the 3.4 branch (closes #29408).

Discussion
----------

[Security] getTargetPath of TargetPathTrait must return string or null

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes (possible bug)
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

Since the return type is string the default return value must be also string.

Commits
-------

8d4b787 [Security] getTargetPath of TargetPathTrait must return string or null
  • Loading branch information
fabpot committed Dec 10, 2018
2 parents 9c84b14 + 8d4b787 commit 68b823f
Showing 1 changed file with 1 addition and 1 deletion.
Expand Up @@ -38,7 +38,7 @@ private function saveTargetPath(SessionInterface $session, $providerKey, $uri)
* @param SessionInterface $session
* @param string $providerKey The name of your firewall
*
* @return string
* @return string|null
*/
private function getTargetPath(SessionInterface $session, $providerKey)
{
Expand Down

0 comments on commit 68b823f

Please sign in to comment.