fix(yml): fix comment in milti line value

symfony · Jul 26, 2019 · 61130c4 · 61130c4
1 parent 61b0f79
commit 61130c4
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/src/Symfony/Component/Yaml/Parser.php b/src/Symfony/Component/Yaml/Parser.php
@@ -386,6 +386,9 @@ private function doParse(string $value, int $flags)
                     $value = '';
 
                     foreach ($this->lines as $line) {
+                        if ('' !== $line && '#' === $line[0]) {
+                            continue;
+                        }
                         // If the indentation is not consistent at offset 0, it is to be considered as a ParseError
                         if (0 === $this->offset && !$deprecatedUsage && isset($line[0]) && ' ' === $line[0]) {
                             throw new ParseException('Unable to parse.', $this->getRealCurrentLineNb() + 1, $this->currentLine, $this->filename);

diff --git a/src/Symfony/Component/Yaml/Tests/ParserTest.php b/src/Symfony/Component/Yaml/Tests/ParserTest.php
@@ -2152,6 +2152,17 @@ public function indentedMappingData()
 
         return $tests;
     }
+
+    public function testMultiLineComment() {
+        $yaml = <<<YAML
+parameters:
+    abc
+
+# Comment 
+YAML;
+
+        $this->assertSame(['parameters' => 'abc'], $this->parser->parse($yaml));
+    }
 }
 
 class B