-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Commit
…nd TagAwareAdapter instances (nicolas-grekas) This PR was merged into the 3.4 branch.
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -282,6 +282,16 @@ public function commit() | |
return $this->invalidateTags([]); | ||
} | ||
|
||
public function __sleep() | ||
{ | ||
throw new \BadMethodCallException('Cannot serialize '.__CLASS__); | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
stof
Member
|
||
} | ||
|
||
public function __wakeup() | ||
{ | ||
throw new \BadMethodCallException('Cannot unserialize '.__CLASS__); | ||
} | ||
|
||
public function __destruct() | ||
{ | ||
$this->commit(); | ||
|
4 comments
on commit 4cc37df
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nicolas-grekas , could you explain to me please why AbstractAdapter.php is fixed only in the 3.4.x branch and TagAwareAdapter.php is fixed in the others as well?
I would like to understand what is the file that is vulnerable and if its AbstractAdapter.php and the fix isn't applied to the other branches then doesn't that mean they're still vulnerable?
Thanks in advance ! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We always merge branches up into all other still maintained branches which means that changes made in 3.4 will be available in more recent versions too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We always merge branches up into all other still maintained branches which means that changes made in 3.4 will be available in more recent versions too.
@xabbuh
I understand but that being said, the fix applied to AbstractAdapter.php does not appear in more recent branches at all..
Like for example, the fix doesn't appear in 4.3.x as far as I could tell.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On upper branches, AbstractAdapter
has been refactored, the patch applies to AbstractAdapterTrait
instead:
https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/Cache/Traits/AbstractAdapterTrait.php
My application is throwing this exception, using Tags as caching strategy. Can some one help ?