Skip to content

Commit

Permalink
[Config] Do not use absolute path when computing the vendor freshness
Browse files Browse the repository at this point in the history
When one uses Docker with a different mounting point between CLI & FPM,
the cache keeps regenerating because the ComposerResource class see a
different path for each SAPI. For example `/home/app/app/vendor` vs
`/var/www/app/vendor`.
So if you hit FPM, then the CLI, then FPM, each time a new cache is
generated. So the application is quite slow in dev env. And for people
on MacOSX (with docker) is a big pain! And obvisouly, this never
stabilizes !

This occurs a lot when you have a worker, that crash and reboot in the
background, and you browse the web interface. Or when you have something
that hit your API every X secondes, and you are working on a worker.
  • Loading branch information
lyrixx committed Jul 17, 2019
1 parent 04b9ce3 commit 2d2e274
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/Symfony/Component/Config/Resource/ComposerResource.php
Expand Up @@ -48,7 +48,7 @@ public function isFresh($timestamp)
{
self::refresh();

return self::$runtimeVendors === $this->vendors;
return array_values(self::$runtimeVendors) === array_values($this->vendors);
}

/**
Expand Down

0 comments on commit 2d2e274

Please sign in to comment.