[Bugfix] MemcachedSessionHandler::close() must close connection

symfony · Jan 6, 2019 · 2bd3c98 · 2bd3c98
1 parent 7f04e55
commit 2bd3c98
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/Symfony/Component/HttpFoundation/Session/Storage/Handler/MemcachedSessionHandler.php b/src/Symfony/Component/HttpFoundation/Session/Storage/Handler/MemcachedSessionHandler.php
@@ -62,7 +62,7 @@ public function __construct(\Memcached $memcached, array $options = array())
      */
     public function close()
     {
-        return true;
+        return $this->memcached->quit();
     }
 
     /**

diff --git a/...ny/Component/HttpFoundation/Tests/Session/Storage/Handler/MemcachedSessionHandlerTest.php b/...ny/Component/HttpFoundation/Tests/Session/Storage/Handler/MemcachedSessionHandlerTest.php
@@ -63,6 +63,11 @@ public function testOpenSession()
 
     public function testCloseSession()
     {
+        $this->memcached
+            ->expects($this->once())
+            ->method('quit')
+            ->with(true);
+
         $this->assertTrue($this->storage->close());
     }