Skip to content

Commit

Permalink
minor #20104 [TwigBundle] Adjust CacheWarmingTest for TemplateCacheWa…
Browse files Browse the repository at this point in the history
…rmer introduced in 2.8 (tucksaun)

This PR was merged into the 2.8 branch.

Discussion
----------

[TwigBundle] Adjust CacheWarmingTest for TemplateCacheWarmer introduced in 2.8

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

With #20103, issue reported in #20065 is fixed, however it will now break in 2.8+ as another cache warmer has been introduced with #16271.

Commits
-------

360ca48 [TwigBundle] Adjust CacheWarmingTest for TemplateCacheWarmer introduced in 2.8
  • Loading branch information
fabpot committed Sep 30, 2016
2 parents fe4ae0b + 360ca48 commit 2081bd9
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public function testCacheIsProperlyWarmedWhenTemplatingIsAvailable()
$this->assertTrue(file_exists($kernel->getCacheDir().'/twig'));
}

public function testCacheIsNotWarmedWhenTemplatingIsDisabled()
public function testCacheIsProperlyWarmedWhenTemplatingIsDisabled()
{
$kernel = new CacheWarmingKernel(false);
$kernel->boot();
Expand All @@ -40,7 +40,7 @@ public function testCacheIsNotWarmedWhenTemplatingIsDisabled()
$warmer->enableOptionalWarmers();
$warmer->warmUp($kernel->getCacheDir());

$this->assertFalse(file_exists($kernel->getCacheDir().'/twig'));
$this->assertTrue(file_exists($kernel->getCacheDir().'/twig'));
}

protected function setUp()
Expand Down

0 comments on commit 2081bd9

Please sign in to comment.