Skip to content

Commit

Permalink
bug #33045 Make HttpClientTestCase compatible with PHPUnit8 (jderusse)
Browse files Browse the repository at this point in the history
This PR was merged into the 4.3 branch.

Discussion
----------

Make HttpClientTestCase compatible with PHPUnit8

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #32844
| License       | MIT
| Doc PR        | NA

the abstract class `HttpClientTestCase` may be extends by end user and execute by both PHPUnit 8 and bellow. Adding a return typehint on it will force all users extending it to add it too and would be a BC Break.

Note. I don't know how to trigger a deprecation here and help user to add it.

Commits
-------

55daf15 Fix compatibility with PHPUnit 8
  • Loading branch information
nicolas-grekas committed Aug 8, 2019
2 parents c0f416e + 55daf15 commit 0abd64b
Showing 1 changed file with 1 addition and 1 deletion.
Expand Up @@ -26,7 +26,7 @@ abstract class HttpClientTestCase extends TestCase
{
private static $server;

public static function setUpBeforeClass()
public static function setUpBeforeClass(): void
{
TestHttpServer::start();
}
Expand Down

0 comments on commit 0abd64b

Please sign in to comment.