[Messenger] Document middleware factories #9774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogizanagi
force-pushed
the
messenger/middleware_factories
branch
2 times, most recently
from
17dae2f
to
4deadc1
Compare
xabbuh
reviewed
May 18, 2018
messenger.rst
Outdated
| @@ -273,6 +273,114 @@ you can disable them like this: | |||
| messenger.bus.default: | |||
| default_middleware: false | |||
|
|
|||
| Using middleware factories | |||
ogizanagi
force-pushed
the
messenger/middleware_factories
branch
from
4deadc1
to
2880027
Compare
ogizanagi
commented
May 23, 2018
messenger.rst
Outdated
| Using Middleware Factories | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| Sometimes middleware are configurable using factories. There are two types of |
There was a problem hiding this comment.
Turned like this, it seems to me the sentence is saying that there are two different ways to achieve configurable middleware, while it's actually two required services definitions. One registering the factory class as a service. The second one allowing to create a middleware instance using the first factory.
There was a problem hiding this comment.
I'm sorry for having changed the meaning of the docs. I've reworded it again to follow your explanation. Cheers!
|
Thanks Maxime. |
javiereguiluz
added a commit
that referenced
this pull request
May 24, 2018
…iereguiluz) This PR was merged into the 4.1 branch. Discussion ---------- [Messenger] Document middleware factories <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Refs: - Symfony PR: symfony/symfony#27128 - DoctrineBundle PR: doctrine/DoctrineBundle#817 Commits ------- c5ef7c8 Reowrd to restore the original meaning a87f21b Minor rewords 2880027 [Messenger] Document middleware factories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: