Extend AbstractBundle instead of Bundle #19873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jibbarth
reviewed
May 9, 2024
bundles/best_practices.rst
Outdated
| class AcmeBlogBundle extends Bundle | ||
| use Symfony\Component\HttpKernel\Bundle\AbstractBundle; | ||
|
|
||
| class AcmeBlogBundle extends AbstractBundle | ||
| { | ||
| public function getPath(): string |
There was a problem hiding this comment.
AFAIK, when we extend AbstractBundle, no need to override this. Maybe we can remove it ?
There was a problem hiding this comment.
Good catch! I committed some changes to explain this differently. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19838.
After this, we use
AbstractBundleeverywhere except for this example which explicitly shows the old way of doing things when extendingBundle: https://symfony.com/doc/current/bundles/extension.html#manually-registering-an-extension-class