Fix doctrine/dbal deprecation using Statement::executeQuery
#18429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
suggested changes
Jun 17, 2023
carsonbot
added
Status: Needs Work
Status: Needs Review
and removed
Status: Needs Review
Status: Needs Work
labels
derrabus
approved these changes
Jun 17, 2023
OskarStark
changed the title
doctrine/dbal deprecation using Statement::executeQuery
OskarStark
approved these changes
Jun 19, 2023
xabbuh
approved these changes
Jun 19, 2023
OskarStark
force-pushed
the
removes_a_doctrine_dbal_deprecation_using_executeQuery
branch
from
f0a5513
to
5c8154b
Compare
|
Thank you Vincent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecation warning when
doctrine/dbal >= 3.4.*.In Symfony docs,executeQuery() is mentionned here : Querying with SQL.
But since
3.4.*passing parameters toStatement::execute*()functions is deprecated bydoctrine/dbalwith this warning:User Deprecated: Passing $params to Statement::executeQuery() is deprecated. Bind parameters using Statement::bindParam() or Statement::bindValue() instead. (Statement.php:212 called by User.php:40, https://github.com/doctrine/dbal/pull/5556, package doctrine/dbal).I've already ask in the DBAL PR concerned how to use
executeQueryfrom now on.(in the same PR)
So, after having tested it in a prod project, I propose an update of the doc in this sense.
Thanks again @derrabus 馃檹