[Validator] Fix @Valid regarding property traverse
#10868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corphi
force-pushed
the
constraint-valid-traverse
branch
2 times, most recently
from
fa004a4
to
49354b4
Compare
corphi
force-pushed
the
constraint-valid-traverse
branch
from
49354b4
to
8ed269f
Compare
corphi
force-pushed
the
constraint-valid-traverse
branch
from
8ed269f
to
0836a48
Compare
HeahDude
reviewed
Feb 16, 2019
| set to ``true``. | ||
| If this constraint is applied to a ``Traversable``, then all containing values | ||
| will be validated if this option is set to ``true``. This option is ignored on | ||
| arrays: Arrays are traversed in either case. Keys are not validated. |
There was a problem hiding this comment.
This should need a correction if symfony/symfony#29800 is merged, right?
There was a problem hiding this comment.
No, @Valid is working correctly. The docs could just use this clarification. The mentioned pull request is only concerned with other constraints not working correctly.
corphi
force-pushed
the
constraint-valid-traverse
branch
from
0836a48
to
6343b24
Compare
|
Thank you @corphi. |
javiereguiluz
added a commit
that referenced
this pull request
Mar 7, 2019
…corphi) This PR was merged into the 3.4 branch. Discussion ---------- [Validator] Fix `@Valid` regarding property `traverse` While researching for symfony/symfony#27090, the constraint reference turned out to be incorrect. Commits ------- 6343b24 Describe actual traversal behaviour
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While researching for symfony/symfony#27090, the constraint reference turned out to be incorrect.