This repository has been archived by the owner on Feb 6, 2022. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
bug #263 decode username and password from url (eeemarv)
This PR was squashed before being merged into the 3.2-dev branch (closes #263). Discussion ---------- decode username and password from url #234 Commits ------- d170a10 decode username and password from url
- Loading branch information
Showing
1 changed file
with
3 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -104,13 +104,13 @@ public static function resolveOptions(array $options) | |
$options['transport'] = $parts['scheme']; | ||
} | ||
if (isset($parts['user'])) { | ||
$options['username'] = $parts['user']; | ||
$options['username'] = rawurldecode($parts['user']); | ||
} | ||
if (isset($parts['pass'])) { | ||
$options['password'] = $parts['pass']; | ||
$options['password'] = rawurldecode($parts['pass']); | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
kcaporaso
|
||
} | ||
if (isset($parts['host'])) { | ||
$options['host'] = $parts['host']; | ||
$options['host'] = rawurldecode($parts['host']); | ||
} | ||
if (isset($parts['port'])) { | ||
$options['port'] = $parts['port']; | ||
|
This seems to break when the password has a "+", like a lot of AWS SES generated passwords have. I get better results when I use 'urldecode'.