Skip to content
This repository has been archived by the owner on Apr 29, 2024. It is now read-only.

defer log message in guard authenticator #13

Closed
wants to merge 1 commit into from
Closed

defer log message in guard authenticator #13

wants to merge 1 commit into from

Conversation

eschultz-magix
Copy link
Contributor

prevent an unneccessary log message if the guard authenticator does not support the current request

prevent an unneccessary log message if the guard authenticator does not support the current request
@symfony-bot
Copy link

symfony-bot bot commented Nov 22, 2018

Thanks for your pull request! We love contributions.

However, this repository is what we call a "subtree split": a read-only copy of one directory of the main Symfony repository. It is used by Composer to allow developers to depend on specific Symfony components.

If you want to contribute, you should instead open a pull request on the main repository:

https://github.com/symfony/symfony

Thank you for your contribution!

PS: if you haven't already, please add tests, and beware that bug fixes should be submitted on the lowest maintained branch where they apply; only features should be submitted against the master branch.

@symfony-bot symfony-bot bot closed this Nov 22, 2018
@chalasr
Copy link
Member

chalasr commented Nov 25, 2018

@eschultz-magix Hey, would you mind resubmitting against https://github.com/symfony/symfony? This qualifies as a bug to me, the log message is indeed wrong at this stage. Should be fixed on the 3.4 branch

@eschultz-magix
Copy link
Contributor Author

eschultz-magix commented Nov 26, 2018

@chalasr Sure, I didn't notice this repository is not made for PR.

I have submitted the PR again as symfony/symfony#29323

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants