Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update recipe for PHP-CS-Fixer 2.19.0 and 3.0.0 #942
Update recipe for PHP-CS-Fixer 2.19.0 and 3.0.0 #942
Changes from 3 commits
2489ad4
d623c65
b19206c
ebc501e
744c936
f029ccd
783b2ec
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nor sure about that @keradus
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PHP CS Fixer uses:
.php_cs.cache
for 2.x.php-cs-fixer.cache
for 3.xThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah so we need to keep
.php_cs.cache
for 2.x and add another recipe for 3.x with.php-cs-fixer.cache
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name is configurable though. I'd suggest to configure PHP CS Fixer to use the new cache file name so we don't need different recipes for 2.19 and 3.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@derrabus good point for maint, but wouldnt it be best to stick with the conventions used in
3.0
? thinking in terms of DX and consistency - e.g.maker-bundle
will usephp-cs-fixer
3.0
but does not depend on recipes. However in our test cases, we do depend on recipes and I can see the potential of the bundle vs tests being out of sync.Another use case would be for other bundles e.g.
symfonycasts
||knplabs
that try to stick as close as possible Symfony conventions. It would be nice to keepphp-cs-fixer
's configuration &&.gitignore
inline with Symfony w/o having to use custom naming conventions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe sth like this: https://github.com/symfony/recipes/pull/942/files#r625770976
then, 2.x and 3.x will use same name of cache file
(and that line can be removed on 3.x, as
.php-cs-fixer.cache
is default name on 3.x)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jrushlow I don't quite get why MakerBundle would have an opinion on how PHP CS Fixer's cache file is named.
What @keradus suggested is exactly what I meant. The 2.19 release prepares the application for the transition to 3.0. If we can configure CS Fixer 2.19 to behave like 3.0, we should do that.