Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable query profiling for debug #704

Merged
4 commits merged into from Jan 10, 2020
Merged

enable query profiling for debug #704

4 commits merged into from Jan 10, 2020

Conversation

ro0NL
Copy link
Contributor

@ro0NL ro0NL commented Dec 6, 2019

Q A
License MIT
Doc issue/PR symfony/symfony-docs#...

IMHO this is rather useful to look into when debugging. Assumed disabling is more easy, then enabling ... yet the proposed default should be best of both.

Hinted in symfony/symfony#18235 (comment)

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

@stof
Copy link
Member

stof commented Dec 6, 2019

The reason why DoctrineBundle disables it by default is that it increases memory usage a lot.

And if you have this turned on in your worker process, you will face a big problem (well, even collecting queries is already an issue).

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

ghost pushed a commit that referenced this pull request Jan 10, 2020
@ghost ghost merged commit f009bca into symfony:master Jan 10, 2020
@ro0NL ro0NL deleted the patch-2 branch January 10, 2020 08:04
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants