Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doctrine-bundle recipe for prod caching pools #695

Merged
1 commit merged into from Nov 28, 2019

Conversation

dmaicher
Copy link
Contributor

@dmaicher dmaicher commented Nov 27, 2019

Q A
License MIT
Doc issue/PR -

This change is required since we reverted some changes on doctrine-bundle to restore non-persistent caches for non-prod environments: doctrine/DoctrineBundle#1073

This fixes some issues that were reported:
#688
doctrine/DoctrineBundle#1069
doctrine/migrations#873

Tested this on symfony-demo with doctrine-bundle 1.12.x

it@7444b85a5a96:/var/www/symfony-demo  (master) $ bin/console debug:container doctrine.orm.default_metadata_cache --env=prod --show-arguments

 // This service is a private alias for the service                                                                     
 // doctrine.orm.cache.provider.doctrine.system_cache_pool                                                              

Information for Service "doctrine.orm.cache.provider.doctrine.system_cache_pool"
================================================================================

 ---------------- -------------------------------------------------------- 
  Option           Value                                                   
 ---------------- -------------------------------------------------------- 
  Service ID       doctrine.orm.cache.provider.doctrine.system_cache_pool  
  Class            Symfony\Component\Cache\DoctrineProvider                
  Tags             -                                                       
  Public           no                                                      
  Synthetic        no                                                      
  Lazy             no                                                      
  Shared           yes                                                     
  Abstract         no                                                      
  Autowired        no                                                      
  Autoconfigured   no                                                      
  Arguments        Service(doctrine.system_cache_pool)                     
 ---------------- -------------------------------------------------------- 

it@7444b85a5a96:/var/www/symfony-demo  (master) $ bin/console debug:container doctrine.system_cache_pool --env=prod --show-arguments

Information for Service "doctrine.system_cache_pool"
====================================================

 Interface for adapters managing instances of Symfony's CacheItem.

 ---------------- -------------------------------------------------- 
  Option           Value                                             
 ---------------- -------------------------------------------------- 
  Service ID       doctrine.system_cache_pool                        
  Class            Symfony\Component\Cache\Adapter\AdapterInterface  
  Tags             cache.pool                                        
                   kernel.reset (method: reset)                      
  Public           no                                                
  Synthetic        no                                                
  Lazy             no                                                
  Shared           yes                                               
  Abstract         no                                                
  Autowired        no                                                
  Autoconfigured   no                                                
  Factory Class    Symfony\Component\Cache\Adapter\AbstractAdapter   
  Factory Method   createSystemCache                                 
  Arguments        ZuhLw62S5q                                        
                   0                                                 
                   %container.build_id%                              
                   /var/www/symfony-demo/var/cache/prod/pools        
                   Service(monolog.logger.cache)                     
 ---------------- -------------------------------------------------- 



Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request passes validation.

ghost pushed a commit that referenced this pull request Nov 28, 2019
@ghost ghost merged commit 2e446d0 into symfony:master Nov 28, 2019
@dmaicher dmaicher deleted the patch-1 branch November 28, 2019 08:44
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants